Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore WASM debug hook #7843

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Dec 3, 2024

No description provided.

@ryzngard ryzngard requested a review from a team as a code owner December 3, 2024 22:07
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@ryzngard
Copy link
Contributor Author

ryzngard commented Dec 3, 2024

🤷‍♂️

I accidentally removed it in https://github.com/dotnet/vscode-csharp/pull/7805/files#diff-c4d31caa27fd3cee620b32cc46182138bc784fb5f20ac68bb4a81bd0c12f1587L304 and I don't know/remember why but it breaks WASM debugging.

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryzngard can you cherry-pick to both the release and prerelease branches?

@ryzngard ryzngard enabled auto-merge (squash) December 3, 2024 22:22
@ryzngard ryzngard merged commit 6193755 into dotnet:main Dec 4, 2024
16 checks passed
@ryzngard ryzngard deleted the fix_debug_register branch December 4, 2024 17:39
ryzngard added a commit to ryzngard/vscode-csharp that referenced this pull request Dec 4, 2024
ryzngard added a commit to ryzngard/vscode-csharp that referenced this pull request Dec 4, 2024
dibarbet added a commit that referenced this pull request Dec 4, 2024
ryzngard added a commit to ryzngard/vscode-csharp that referenced this pull request Dec 4, 2024
ryzngard added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants