Add failure handling for file integrity check #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now what is hitting the EPERM and ENOENT errors. We need to skip the check and see what happens from here, such as allowing to elevate via windows. This also adds specific handlers for when we fail to download the SDK.
MiYanni
approved these changes
Jul 16, 2024
Comment on lines
187
to
188
| const yes = validationPromptConstants.allowOption | ||
| const no = validationPromptConstants.cancelOption; |
There was a problem hiding this comment.
nit: I know semicolons are not required, but maybe it should be in the .editorconfig/tslint.json to suggest them for consistency? Here, the yes line doesn't have one.
There was a problem hiding this comment.
Good catch! unfortunately I couldnt find an editorconfig setting, it looks like there might be an eslint one. First, we would need to change from tslint to eslint, so I think that should be done separately
nagilson
commented
Jul 16, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now what is hitting the EPERM and ENOENT errors. We need to skip the check and see what happens from here, such as allowing to elevate via windows.
This also adds specific handlers for when we fail to download the SDK.