Separate 1 Lock into 2 Mutexes/Locks for Data Management #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will yield performance improvements.
nagilson
commented
Jul 18, 2024
officialmofabs
approved these changes
Jul 22, 2024
officialmofabs
approved these changes
Jul 22, 2024
officialmofabs
approved these changes
Jul 22, 2024
smitpatel
reviewed
Jul 29, 2024
vscode-dotnet-runtime-library/src/Acquisition/InstallTrackerSingleton.ts
Show resolved
Hide resolved
smitpatel
reviewed
Jul 29, 2024
vscode-dotnet-runtime-library/src/Acquisition/InstallTrackerSingleton.ts
Show resolved
Hide resolved
smitpatel
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'installing' and 'installed' data that is stored in the extension state is preserved between runs. We allow concurrent requests. Sometimes, a request may come in while another request is currently processing. Therefore, we have a lock guard on the install request tracking, so for example, if two identical requests come in at the same time, there is no race condition where the request work gets duplicated.
The promise chain which stores currently in progress installs used to be held behind a lock as well but this doesn't make sense because it's a local data structure, operations on it should be atomic.
We can separate the lock shared for all of these things into 2 separate locks since their operations are discrete from one another to improve performance and stability.