Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint #1944

Merged
merged 26 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
0be4e20
get eslint running but its failing a lot of checks
nagilson Sep 9, 2024
d38b11a
Fix the linting after migration
nagilson Sep 9, 2024
2793466
Fix many errors
nagilson Sep 9, 2024
9f8ec64
65 errors to go
nagilson Sep 9, 2024
f698adb
fix almost every lint issue
nagilson Sep 10, 2024
63ac199
clean lint
nagilson Sep 10, 2024
cd5d1b0
Remove references to tslint
nagilson Sep 10, 2024
e6892b6
dont install eslint as it is already here
nagilson Sep 10, 2024
3014826
install eslint
nagilson Sep 10, 2024
666a447
update eslint
nagilson Sep 10, 2024
639d3db
dont empty cache because eslint is failing to register the types that…
nagilson Sep 10, 2024
3748b27
try to help eslint find the files for type defs
nagilson Sep 10, 2024
fe6fba6
Set typescript resolver
nagilson Sep 10, 2024
430813e
Fix imports
nagilson Sep 10, 2024
12e96a9
Add some import plugin but still cant import vscode correctly
nagilson Sep 10, 2024
b51f0a3
install eslint globally
nagilson Sep 10, 2024
63a50ae
skip npm installl
nagilson Sep 10, 2024
1c7fcfb
add imports
nagilson Sep 10, 2024
074b664
try to fix the import issue
nagilson Sep 10, 2024
e5381b4
build before hand so the types are picked up -_____-
nagilson Sep 10, 2024
be19118
Revert "build before hand so the types are picked up -_____-"
nagilson Sep 10, 2024
1b933e1
rollback to eslint 8 but still run build
nagilson Sep 10, 2024
4adddc7
fix settings option
nagilson Sep 10, 2024
56f3f36
Delete yarn-error.log
nagilson Sep 10, 2024
a121653
fix condition for pipeline (this will cause a merge conflict later tm)
nagilson Sep 10, 2024
65f8cb4
Merge branch 'nagilson-eslint' of https://github.com/nagilson/vscode-…
nagilson Sep 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
193 changes: 193 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,193 @@
module.exports = {
"env": {
"browser": true,
"es6": true
},
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"prettier"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "tsconfig.eslint.json",
"sourceType": "module"
},
"plugins": [
"eslint-plugin-jsdoc",
"eslint-plugin-prefer-arrow",
"@typescript-eslint",
"@typescript-eslint/tslint",
],
"root": true,
"rules": {
"@typescript-eslint/adjacent-overload-signatures": "error",
"@typescript-eslint/array-type": "off",
"@typescript-eslint/ban-types": [
"error",
{
"types": {
"Object": {
"message": "Avoid using the `Object` type. Did you mean `object`?"
},
"Function": {
"message": "Avoid using the `Function` type. Prefer a specific function type, like `() => void`."
},
"Boolean": {
"message": "Avoid using the `Boolean` type. Did you mean `boolean`?"
},
"Number": {
"message": "Avoid using the `Number` type. Did you mean `number`?"
},
"String": {
"message": "Avoid using the `String` type. Did you mean `string`?"
},
"Symbol": {
"message": "Avoid using the `Symbol` type. Did you mean `symbol`?"
}
}
}
],
"@typescript-eslint/consistent-type-assertions": "error",
"@typescript-eslint/dot-notation": "error",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/only-throw-error": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/naming-convention": [
"off",
{
"selector": "variable",
"format": [
"camelCase",
"UPPER_CASE"
],
"leadingUnderscore": "forbid",
"trailingUnderscore": "forbid"
}
],
"@typescript-eslint/no-empty-interface": "error",
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/no-unsafe-call": "warn",
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/prefer-promise-reject-errors": "warn",
"@typescript-eslint/no-inferrable-types": "error",
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-misused-promises": "warn",
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-parameter-properties": "off",
"@typescript-eslint/no-shadow": [
"error",
{
"hoist": "all"
}
],
"@typescript-eslint/no-unused-expressions": "error",
"@typescript-eslint/restrict-template-expressions": [
"error",
{
"allowNumber": true,
"allowBoolean": true,
"allowAny": true,
"allowArray": true
}
],
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/prefer-for-of": "error",
"@typescript-eslint/no-unused-vars": "off",
"@typescript-eslint/prefer-function-type": "error",
"@typescript-eslint/prefer-namespace-keyword": "error",
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-require-imports": "off",
"@typescript-eslint/no-unsafe-argument": "off",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-unnecessary-type-assertion": "off",
"@typescript-eslint/quotes": "off",
"@typescript-eslint/triple-slash-reference": [
"error",
{
"path": "always",
"types": "prefer-import",
"lib": "always"
}
],
"@typescript-eslint/typedef": "off",
"@typescript-eslint/unified-signatures": "error",
"arrow-parens": [
"off",
"always"
],
"complexity": "off",
"constructor-super": "error",
"dot-notation": "off",
"eqeqeq": [
"error",
"smart"
],
"guard-for-in": "error",
"id-denylist": "error",
"id-match": "error",
"jsdoc/check-alignment": "error",
"jsdoc/check-indentation": "error",
"jsdoc/newline-after-description": "off",
"max-classes-per-file": "off",
"max-len": [
"error",
{
"code": 300
}
],
"new-parens": "error",
"no-bitwise": "error",
"no-caller": "error",
"no-cond-assign": "error",
"no-console": "off",
"no-debugger": "error",
"no-empty": "off",
"no-empty-function": "off",
"no-eval": "error",
"no-fallthrough": "off",
"no-invalid-this": "off",
"no-new-wrappers": "error",
"no-return-await": "error",
"no-shadow": "off",
"no-throw-literal": "error",
"no-trailing-spaces": "error",
"no-undef-init": "error",
"no-underscore-dangle": "error",
"no-unsafe-finally": "error",
"no-unused-expressions": "off",
"no-unused-labels": "error",
"no-use-before-define": "off",
"no-var": "error",
"object-shorthand": "error",
"one-var": [
"error",
"never"
],
"prefer-arrow/prefer-arrow-functions": "off",
"prefer-const": "error",
"prefer-template": "error",
"quotes": "off",
"no-underscore-dangle": "off",
"radix": "error",
"use-isnan": "error",
"valid-typeof": "off",
"@typescript-eslint/tslint/config": [
"error",
{
"rules": {
"file-header": [
true,
"------"
]
}
}
]
},
"settings": {
"typescript": {}
}
};
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ project.lock.json
*.*sdf
*.ipch
*.js
!.eslintrc.js
*.d.ts
*.js.map
.build/
Expand Down
11 changes: 10 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,14 @@
"REGTYPE",
"Republisher"
],
"azure-pipelines.1ESPipelineTemplatesSchemaFile": true
"azure-pipelines.1ESPipelineTemplatesSchemaFile": true,
"eslint.options": {
"configFile": ".eslintrc.js"
},
"eslint.workingDirectories": [
"./vscode-dotnet-runtime-library",
"./vscode-dotnet-runtime-extension",
"./vscode-dotnet-sdk-extension",
"./sample"
]
}
1 change: 0 additions & 1 deletion .vscodeignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
node_modules/**
dist/test/**
src/**
tslint.json
*.vsix
packages/
msbuild/**
Expand Down
Loading
Loading