Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ChannelTerminatedException to correct namespace section. #2571

Closed
wants to merge 1 commit into from
Closed

Move ChannelTerminatedException to correct namespace section. #2571

wants to merge 1 commit into from

Conversation

StephenBonikowsky
Copy link
Member

@StephenBonikowsky
Move ChannelTerminatedException to correct namespace section.
225663b 
* Moved ChannelTerminatedException from System.ServiceModel.Channels to System.ServiceModel
@zhenlan
Copy link
Member

zhenlan commented Feb 15, 2018

@StephenBonikowsky, I think it's okay not to include these APIs changes in the 2.1 preveiw1 release. Once preview1 is released, we will rebase the 2.1 branch from master and all your changes will be included in the next 2.1 release.

@StephenBonikowsky
Copy link
Member Author

Ok, sounds good, then I also won't cherry-pick the other API changes I've been making.

@StephenBonikowsky StephenBonikowsky deleted the stebon/2.1/PortMasterPR2564 branch May 30, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconnew mconnew Awaiting requested review from mconnew

@zhenlan zhenlan Awaiting requested review from zhenlan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenBonikowsky @zhenlan