Add vNext UAP TFM as Inbox #2689
Conversation
|
I came to this conclusion based on System.Buffers in CoreFx... |
|
I'm doing a test build in VSO right now to confirm. |
StephenBonikowsky
force-pushed
the
stebon/uwp6.1/InboxUapTfm
branch
2 times, most recently
from
f22d10a
to
82bfbb8
Compare
| @@ -20,6 +20,8 @@ | |||
| <InboxOnTargetFramework Include="xamarinmac20" /> | |||
| <InboxOnTargetFramework Include="xamarintvos10" /> | |||
| <InboxOnTargetFramework Include="xamarinwatchos10" /> | |||
| <InboxOnTargetFramework Include="$(UAPvNextTFM)" /> | |||
There was a problem hiding this comment.
This puts placeholders in your package for UAP. Can you confirm that this is indeed what you want?
There was a problem hiding this comment.
we said earlier that we instead wanted to still treat this as out of box to be able to service it separately, are we sure we don’t want this?
There was a problem hiding this comment.
@zhenlan and I have been discussing and still don't completely understand this whole issue. Could you give us your recommendations please. As it currently is this PR is failing in VSO...
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build?_a=summary&buildId=1487178
There is some issue with reference and implementation assemblies for uap10.0.16300. Adding it as InboxOnTargetFramework in the pkg project doesn't solve it.
There was a problem hiding this comment.
In uwp6.1 branch you need to update your package index to correctly represent what you shipped in uwp6.0. You should leave the packages suppressing TreatAsOutOfBox on UAP. That way you can continue to build these packages as standalone and allow folks to get a new version of WCF by getting a newer package.
|
I am investigating what I need in buildtools to make it understand the TreatAsOutOfBox property and then I will update this PR. |
* In uwp6.1 branch the UAP vNext TFM needs to be listed as inbox.
StephenBonikowsky
force-pushed
the
stebon/uwp6.1/InboxUapTfm
branch
from
82bfbb8
to
2886881
Compare
|
This PR is no longer applicable, based on the decision arrived at as part of #2687 I'll open a new PR. |
Fixes #2687