Fixed problem with HTTP streamed mode timeout #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropriate CancellationToken when reading from the stream
|
@mconnew Should we add a scenario test for this? |
mconnew
added
the
PR DO NOT MERGE
|
Normally I'd say yes, but writing a scenario test to try and hit this would require not using WCF on the server side and taken more direct control of sending the response. As there's no logic flow change, simply propagating a timeout to calls which should have been using it, I think we can make do without scenario tests for this one. |
mconnew
removed
the
PR DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing an appropriate CancellationToken when reading from the stream.
Fixes #3590