Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory m… #5343

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Port Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory m… #5343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e76818
Port Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory m…
HongGit Nov 2, 2023
28422f6
Remove dotnet-blob-feed
HongGit Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions azure-pipelines-arcade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,12 @@ stages:
# Internal/Official Build Variables
- ${{ if eq(variables._RunAsInternal, True) }}:
# Only enable publishing in non-public, non PR scenarios.
# DotNet-Blob-Feed provides: dotnetfeed-storage-access-key-1
# Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT
# DotNet-HelixApi-Access provides: HelixApiAccessToken
- group: DotNet-Blob-Feed
- group: Publish-Build-Assets
- group: DotNet-HelixApi-Access
- _PublishBlobFeedUrl: https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
- _InternalBuildArgs: /p:DotNetSignType=$(_SignType) /p:TeamName=$(_TeamName)
/p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
/p:DotNetPublishBlobFeedUrl=$(_PublishBlobFeedUrl)
/p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
/p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
/p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
Expand Down
6 changes: 5 additions & 1 deletion src/System.ServiceModel.NetTcp/src/System/ServiceModel/Channels/SocketAwaitableEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ internal class SocketAwaitableEventArgs : SocketAsyncEventArgs, IValueTaskSource
{
private static readonly Action<object> _continuationCompleted = _ => { };

private Action<object> _continuation;
// There are places where we read the _continuation field and then read some other state which we assume to be consistent
// with the value we read in _continuation. Without a fence, those secondary reads could be reordered with respect to the first.
// https://github.com/dotnet/runtime/pull/84432
// https://github.com/dotnet/aspnetcore/issues/50623
private volatile Action<object> _continuation;

public SocketAwaitableEventArgs() : base(unsafeSuppressExecutionContextFlow: true) { }

Expand Down
6 changes: 5 additions & 1 deletion ...erviceModel.UnixDomainSocket/src/System/ServiceModel/Channels/SocketAwaitableEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ internal class SocketAwaitableEventArgs : SocketAsyncEventArgs, IValueTaskSource
{
private static readonly Action<object> _continuationCompleted = _ => { };

private Action<object> _continuation;
// There are places where we read the _continuation field and then read some other state which we assume to be consistent
// with the value we read in _continuation. Without a fence, those secondary reads could be reordered with respect to the first.
// https://github.com/dotnet/runtime/pull/84432
// https://github.com/dotnet/aspnetcore/issues/50623
private volatile Action<object> _continuation;

public SocketAwaitableEventArgs() : base(unsafeSuppressExecutionContextFlow: true) { }

Expand Down
Loading