Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate SBOM manifest #2651

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Generate SBOM manifest #2651

merged 8 commits into from
Mar 1, 2022

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Feb 25, 2022

Relates to dotnet/arcade#8477

@epananth
Copy link
Member

Can you please add a test build to this?

@RussKie
Copy link
Member Author

RussKie commented Feb 25, 2022

@epananth
Copy link
Member

Test build did not generate sbom folders

@mmitche
Copy link
Member

mmitche commented Feb 25, 2022

@RussKie I think it would be better to switch this repo to use the jobs template. We need to generate the SBOM for the build legs as well as the Prepare for Publish stage https://dev.azure.com/dnceng/internal/_build/results?buildId=1632434&view=logs&j=4d50a8bf-a143-51c7-5cc8-defff437e23b&t=0b0b242f-bbcb-57b5-fe9f-26dc042642ec

@RussKie
Copy link
Member Author

RussKie commented Feb 26, 2022

Here's a build with SBOM manifest: https://dev.azure.com/dnceng/internal/_build/results?buildId=1633615&view=logs&j=5ab303af-16db-5f58-82d4-945dcabe3bb5&t=24962100-60d4-5768-b736-1d1c025ebd15

@mmitche I added a SBOM step the Prepare for Publish stage, but it's giving me an error. Did I do it incorrectly?

@epananth
Copy link
Member

Looked at the build

  1. SBOMs are getting generated in the Build stage
  2. we don't need another sbom in prepare artifact stage ( I think all the artifacts are covered in previous stage)

@@ -83,6 +83,12 @@ stages:
pool:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2019
- job: Generate_SBOM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this here

@mmitche
Copy link
Member

mmitche commented Feb 28, 2022

Looked at the build

  1. SBOMs are getting generated in the Build stage
  2. we don't need another sbom in prepare artifact stage ( I think all the artifacts are covered in previous stage)

Can we get rid of that stage then? If it's not doing anything interesting any longer. It used to do something around signing and packaging.

@epananth
Copy link
Member

Yes will do

@epananth
Copy link
Member

epananth commented Mar 1, 2022

I was trying to remove the prepared artifacts stage, looks like there is some copying of intermediate packages in that job. I am not sure if that is required. I think it will be good to handle that stage removal in a separate PR

@RussKie
Copy link
Member Author

RussKie commented Mar 1, 2022

Here's an updated build without SBOM in Prepare for Publish stage: https://dev.azure.com/dnceng/internal/_build/results?buildId=1637247&view=results

@RussKie
Copy link
Member Author

RussKie commented Mar 1, 2022

In the interest of time I'm going to merge this, and we can follow up on anything outstanding later.

@RussKie RussKie merged commit b01b80e into main Mar 1, 2022
@RussKie RussKie deleted the sbom_step branch March 1, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants