Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm64 zip and runtime pack nuget generation #757

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Apr 24, 2020

Fixes #530

@AdamYoblick
Copy link
Member

I'm not familiar enough with this repo nor the crossgen process to comment on this PR. It looks good to me, but Davis would know much better. 😄

Where can I check that the artifacts are, in fact, native arm64 binaries? The output of this build only seems to have logs...do we have to wait for a non-pr build to get real artifacts?

@NikolaMilosavljevic
Copy link
Member Author

Where can I check that the artifacts are, in fact, native arm64 binaries? The output of this build only seems to have logs...do we have to wait for a non-pr build to get real artifacts?

You can check my test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=615784&view=results

All packages will be in artifact called "PreparedArtifacts"

…dleproj

Co-Authored-By: Davis Goodin <dagood@users.noreply.github.com>
@hmartinez82
Copy link
Contributor

hmartinez82 commented Apr 30, 2020

@NikolaMilosavljevic I saw you updated the build code. But I just tried to run
D:\Dev\Github\windowsdesktop [master ≡]> .\build.cmd -c Release -platform arm64 and it gave me x64 binaries.

How can one build the arm64 locally?

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 1, 2020

@NikolaMilosavljevic I saw you updated the build code. But I just tried to run
D:\Dev\Github\windowsdesktop [master ≡]> .\build.cmd -c Release -platform arm64 and it gave me x64 binaries.

How can one build the arm64 locally?

build /p:TargetArchitecture=arm64

TargetArchitecture is used in official build to specify correct architecture.

Specified here:

targetArchitecture: arm64

And here it is passed to the build system:

/p:TargetArchitecture=${{ parameters.targetArchitecture }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please generate win-arm64 zip and runtime pack
4 participants