-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable arm64 zip and runtime pack nuget generation #757
Enable arm64 zip and runtime pack nuget generation #757
Conversation
I'm not familiar enough with this repo nor the crossgen process to comment on this PR. It looks good to me, but Davis would know much better. 😄 Where can I check that the artifacts are, in fact, native arm64 binaries? The output of this build only seems to have logs...do we have to wait for a non-pr build to get real artifacts? |
You can check my test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=615784&view=results All packages will be in artifact called "PreparedArtifacts" |
pkg/windowsdesktop/sfx/Microsoft.WindowsDesktop.App.Bundle.bundleproj
Outdated
Show resolved
Hide resolved
…dleproj Co-Authored-By: Davis Goodin <dagood@users.noreply.github.com>
@NikolaMilosavljevic I saw you updated the build code. But I just tried to run How can one build the arm64 locally? |
build /p:TargetArchitecture=arm64 TargetArchitecture is used in official build to specify correct architecture. Specified here: windowsdesktop/azure-pipelines.yml Line 67 in caaf3d8
And here it is passed to the build system: windowsdesktop/eng/jobs/windows-build.yml Line 34 in caaf3d8
|
Fixes #530