V2 of WinForms Async experimental APIs #11854
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11854 +/- ##
===================================================
- Coverage 74.84593% 74.81867% -0.02726%
===================================================
Files 3015 3016 +1
Lines 629433 629649 +216
Branches 46717 46737 +20
===================================================
- Hits 471105 471095 -10
- Misses 154965 155185 +220
- Partials 3363 3369 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/src/System/Windows/Forms/Control_InvokeAsync.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
📭 waiting-author-feedback
| @@ -5,6 +5,8 @@ namespace System.Windows.Forms.Analyzers.Diagnostics; | |||
|
|
|||
| internal static class DiagnosticIDs | |||
| { | |||
| public const string UrlFormat = "https://aka.ms/winforms-experimental/{0}"; | |||
There was a problem hiding this comment.
Sorry I missed this. We should make this more generic like Runtime does:
| public const string UrlFormat = "https://aka.ms/winforms-experimental/{0}"; | |
| public const string UrlFormat = "https://aka.ms/winforms-warnings/{0}"; |
There was a problem hiding this comment.
My thinking is that we later have more AKAs, like winforms-experimental and winforms-warnings and ... so we can have more landing pages for categories. But I have no preference. If you want this all warnings, I can create a new alias.
There was a problem hiding this comment.
Let's start with following the libraries pattern.
There was a problem hiding this comment.
NB: now you have two copies of the same const:
There was a problem hiding this comment.
@RussKie thanks for pointing this out. We'll clean it up.
src/System.Windows.Forms/src/System/Windows/Forms/Control_InvokeAsync.cs
Outdated
Show resolved
Hide resolved
KlausLoeffelmann
force-pushed
the
WinFormsAsync2
branch
2 times, most recently
from
d70819b
to
36e5c27
Compare
src/System.Windows.Forms/src/System/Windows/Forms/Dialogs/TaskDialog/TaskDialog.cs
Outdated
Show resolved
Hide resolved
KlausLoeffelmann
force-pushed
the
WinFormsAsync2
branch
from
4c997a8
to
94de3b9
Compare
|
Fixes #4631 |
|
Verified it in Winforms Release/9.0 branch, we can see these Async APIs. |
|
Verified the issue with .NET 9.0.100-rc.1.24422.10 test pass build, for now the InvokeAsync. ShowAsync, ShowDialogAsync APIs has been implemented. |
|
Verified the issue with .NET 9.0.100-rc.1.24452.12 test pass build, for now the InvokeAsync. ShowAsync, ShowDialogAsync APIs has been implemented. |
Introduces new experimental APIs for .NET 9:
Control.InvokeAsync.TaskDialog.ShowDialogAsync.Form.ShowAsync.Form.ShowDialogAsyncFixes #10739.
Replaces: #11828
Replaces: #9827