Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add COLORREF helper class and move COLORREF methods there #2218

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Add COLORREF helper class and move COLORREF methods there #2218

merged 1 commit into from
Oct 30, 2019

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Oct 27, 2019 •
edited by ghost
Loading

Proposed changes

  • Add COLORREF helper class.
  • Move COLORREF methods from SafeNativeMethods there and update usages.
Microsoft Reviewers: Open in CodeFlow

@gpetrou gpetrou requested a review from a team as a code owner October 27, 2019 18:59
@codecov
Copy link

codecov bot commented Oct 27, 2019 •
edited
Loading

Codecov Report

Merging #2218 into master will decrease coverage by 0.06617%.
The diff coverage is 50%.

@@                 Coverage Diff                 @@
##              master       #2218         +/-   ##
===================================================
- Coverage   29.29546%   29.22928%   -0.06618%     
===================================================
  Files            939         939                 
  Lines         266584      266582          -2     
  Branches       37939       37939                 
===================================================
- Hits           78097       77920        -177     
- Misses        183257      183438        +181     
+ Partials        5230        5224          -6
Flag Coverage Δ
#Debug 29.22928% <50%> (-0.06618%) ⬇️
#production 29.22928% <50%> (-0.06618%) ⬇️
#test 100% <ø> (ø) ⬆️

@JeremyKuhne JeremyKuhne mentioned this pull request Oct 27, 2019
Closed
JeremyKuhne
JeremyKuhne previously approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit and a philosophical musing. Otherwise, looks good.

@RussKie RussKie added the 📭 waiting-author-feedback The team requires more information from the author label Oct 28, 2019
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 30, 2019
JeremyKuhne
JeremyKuhne approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JeremyKuhne JeremyKuhne merged commit 1e0caec into dotnet:master Oct 30, 2019
@ghost ghost added this to the 5.0 milestone Oct 30, 2019
@gpetrou gpetrou deleted the COLORREF branch November 28, 2019 07:36
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs left review comments

@RussKie RussKie RussKie left review comments

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

Assignees

@gpetrou gpetrou

Labels
None yet
Projects
None yet
Milestone
5.0 Previews 1-4
Development

Successfully merging this pull request may close these issues.
4 participants
@gpetrou @RussKie @JeremyKuhne @bartonjs