Adding dotnet3.1/dotnet-eng packages sources #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to remove dependencies on sleet from release branches, it is neccessary to preemptively add these sources so that mehanisms will be able to restore these packages. Sleet must be removed because of it's strong dependency on spcific nuget.packaging versions, which are not stable between 3.0 and 3.1 causing method load exceptions.
RussKie
approved these changes
Aug 27, 2020
|
@msftbot merge when @mmitche approves |
automerge
mmitche
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
@wtgodbe @silvioguiso This is here because we will need to stop publishing packages to dotnet-core for 3.1 because of incompatibilities between the 3.1 SDK and the version of nuget that the dotnet-core feed requires (it's a blob feed).
We are preparing the other side of this change in arcade 3.x. Feel free to check this in when you want, but if builds are working at the moment and not blocked it could wait till the next release.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove dependencies on sleet from release branches,
it is neccessary to preemptively add these sources so that mehanisms
will be able to restore these packages.
Sleet must be removed because of it's strong dependency on spcific
nuget.packaging versions, which are not stable between 3.0 and 3.1
causing method load exceptions.
Microsoft Reviewers: Open in CodeFlow