Rewrite MAUI PropertyGridView, MDI and ImageList tests #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Andrianov
requested review from
RussKie,
SergeySmirnov-Akvelon,
vladimir-krestov,
Tanya-Solyanik and
dreddy-work
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
5af8c18 to
344e6e2
Compare
Danil-Andrianov
added
the
waiting-review
vladimir-krestov
previously approved these changes
Dec 28, 2021
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
31a3b7c to
7de1a80
Compare
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
7de1a80 to
6b5d224
Compare
| using System.Runtime.Serialization.Formatters.Binary; | ||
| using System.Windows.Forms.TestUtilities; | ||
| using Xunit; | ||
|
|
||
| namespace System.Windows.Forms.Tests | ||
| { | ||
| using static Interop; |
There was a problem hiding this comment.
Could you please clarify why did you put this using into the namespace? Just trying to figure out why some of usings are inside the namespace and others are outside of it.
There was a problem hiding this comment.
VS works better when using directives are outside the namespace block.
The difference is in order of resolution of external types, first compiler searches within the namespace, including namespaces declared in the inner using directives, and then in namespaces listed in the outer using directives. So it's best not to mix inner and outer directives.
There was a problem hiding this comment.
Thank you for pointing that out, it's mere an inaccuracy from my side.
|
@Danil-Andrianov - please investigate test failures |
Tanya-Solyanik
added
📭 waiting-author-feedback
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ImageListTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/MDITests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/MDITests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/MDITests.cs
Outdated
Show resolved
Hide resolved
...sts/UnitTests/System/Windows/Forms/PropertyGridView.PropertyGridViewAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ImageListTests.cs
Outdated
Show resolved
Hide resolved
ghost
removed
the
📭 waiting-author-feedback
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
6b5d224 to
f39c947
Compare
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
3 times, most recently
from
d65e3c3 to
59fabf4
Compare
7 tasks
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
59fabf4 to
54b4958
Compare
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
4 times, most recently
from
5a4eb4c to
b7e6ecd
Compare
RussKie
reviewed
Jan 19, 2022
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ImageListTests.cs
Show resolved
Hide resolved
| }; | ||
| childForm.MdiParent = form; | ||
|
|
||
| form.Show(); |
There was a problem hiding this comment.
The container form is already shown and focused.
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/PropertyGridViewTests.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
📭 waiting-author-feedback
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
b7e6ecd to
2ebd151
Compare
ghost
removed
the
📭 waiting-author-feedback
Danil-Andrianov
added
draft
dreddy-work
reviewed
Jan 20, 2022
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/MDITests.cs
Outdated
Show resolved
Hide resolved
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
2ebd151 to
4e09ec7
Compare
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
2 times, most recently
from
f4d03f0 to
ef7a09a
Compare
RussKie
reviewed
Jan 21, 2022
src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/MDITests.cs
Outdated
Show resolved
Hide resolved
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
2 times, most recently
from
3f996cc to
e14bb90
Compare
Danil-Andrianov
force-pushed
the
MAUISmallTestsPart3
branch
from
e14bb90 to
ec1a540
Compare
RussKie
approved these changes
Jan 24, 2022
RussKie
added
test-enhancement
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #3617
Proposed changes
Microsoft Reviewers: Open in CodeFlow