Keep apphostpack version in sync with targeting and runtime pack version #10030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks dotnet/sdk#43015 WPF uses a "live" version of the .NETCoreApp targeting and runtime pack. Also use the live version for the apphost pack so that vcxprojs don't depend on the version inside the SDK.
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
akoeplinger
previously approved these changes
Nov 4, 2024
ericstj
reviewed
Nov 4, 2024
|
@dotnet/wpf-developers can you please review/approve this PR? This is needed to unblock the VMR and .NET 10 / net10.0 effort in the SDK. We can eventually get some of these changes cleaned-up / removed by enabling vcxproj NuGet support. |
akoeplinger
approved these changes
Nov 5, 2024
dipeshmsft
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/sdk#43015
Alternative to #10028
WPF uses vcxprojs which don't support downloading PackageReferences via NuGet. There's an experimental feature switch but enabling that didn't work (see #10028). Therefore, vcxprojs are dependent on the pre-downloaded "packs" folder content in the SDK layout.
Today, wpf projects target
net9.0with a 9.0 SDK but when building the repo inside the VMR, a 10.0.100-alpha SDK is used. That SDK only contains 10.0.0-alpha targeting packs, runtime packs and apphosts. But as wpf targets net9.0 it needs the 9.0.0 assets. The solution to that is using the "live" runtime assets to not depend on the SDK.This repo already uses live assets from runtime but that logic is disabled for vcxprojs and didn't include apphost packs. This PR enables that.
The Tools.props change and the added target in
RuntimeFrameworkReference.targetscan be deleted when vcxprojs support NuGet restore. I don't want to block the SDK PR on such a change though as that might take longer.Fixes #
Main PR
Description
Customer Impact
Regression
Testing
Risk
Microsoft Reviewers: Open in CodeFlow