Consolidate GenerateTemporaryTargetAssembly in to a single task/target #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d new temporary assembly compilation paths in to a single task
ghost
added
the
ghost
requested review from
batzen
reviewed
Dec 9, 2020
| </PropertyGroup> | ||
|
|
||
| <Error Condition="Exists('$(_TempProjectNuGetExtensionsPath)')" | ||
| Text="$(_TempProjectNuGetExtensionsPath) should not exist. This is directory name is randomly generated for each temp project compilation." /> |
There was a problem hiding this comment.
"This is directory name is randomly generated for each temp project compilation" should be
"This directory name is randomly generated for each temp project compilation"
lindexi
reviewed
Dec 11, 2020
| { | ||
| try | ||
| { | ||
| File.Delete(TemporaryTargetAssemblyProjectName); |
There was a problem hiding this comment.
Should we check the TemporaryTargetAssemblyProjectName is null ?
[release/5.0] Support source generators in WPF projects (#3846) [5.0.2 servicing]
|
A similar fix went in to 5.0 servicing. That change will be moved to master instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate GenerateTemporaryTargetAssembly in to a single task/target
The original PR contained three new targets and tasks:
This change combines the two GenerateTemporaryTargetAssembly task/targets in to a single task/target.