Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAssembly tests run with Playwright #1285

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 2, 2024

Following suggestion in microsoft/playwright#32897 (comment), we would like to shift the responsibility of managing chromium to the testing framework in WebAssembly tests. We can do it easily in Wasm.Build.Tests where we utilize Playwright. However, in library tests we are using Selenium. Selenium does not provide management over installing and locating the browser.
To keep all the WASM tests running on the same browser version, we would like to switch to Playwright in the library tests as well. This PR tries to achieve it, without loosing the original functionalities.

@ilonatommy ilonatommy added test-runners TestRunner area wasm WASM area labels Oct 2, 2024
@ilonatommy ilonatommy self-assigned this Oct 2, 2024
@ivanpovazan
Copy link
Member

Would this resolve #974 ?

@ilonatommy
Copy link
Member Author

Yes, but the original reason was to fix dotnet/runtime#107771 by allowing default chromium in WasmBuildTests. If we do it, we would like to keep browser versions in line across our tests (both WasmBuildTest run by runtime and library tests run by xharness).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-runners TestRunner area wasm WASM area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants