-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][testing] hosting webSocket echo server in xharness process #593
Conversation
@akoeplinger could you please comment on topics in the description ? Thank you. |
Right now, I'm thinking that the new echo endpoints should stay in runtime repository in form of assembly, which could be offered to xharness as a binary plugin.
@lewing your thoughts ? |
- set env variables to pass server host to unit test
7d12be1
to
478bc6b
Compare
Could you please explain what this is doing, and why, in the PR description? |
src/Microsoft.DotNet.XHarness.CLI/CommandArguments/TestCommandArguments.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmBrowserTestRunner.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs
Show resolved
Hide resolved
great feedback @radical, thanks! |
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/JS/WasmTestCommand.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment var expansion stuff could maybe be done outside the wasm commands, but that can be done later when we can see how they get used for non-wasm cases.
LGTM! Thank you for the PR, and patience with the feedback 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the ping on this one, looks good to me thank you!
In case that we are running unit tests in xharness, we would like to be able to host webserver in the xharness process rather than to call external servers in azure.
That would allow us to move some unit tests from outer loop to inner loop. See dotnet/runtime#52923
Part of overall epic dotnet/runtime#42852