fix intercept method with out decimal error #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nivalxer <nivalxer@gmail.com>
liuhaoyang
requested changes
Apr 14, 2021
| else ilGenerator.Emit(OpCodes.Ldarg, index); | ||
| break; | ||
| } | ||
| ilGenerator.Emit(OpCodes.Ldarg, index); |
There was a problem hiding this comment.
恩，我看上游没有check，所以我就改了。已还原。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.修复当方法中包含out decimal时，加上拦截器，在.net5.0下会报内存错误，在.netcoreapp3.1下会out参数未正确返回（即返回值未赋值）的问题。（ProxyGeneratorUtils.cs中修复）
2.调试过程中更新了部分ILGeneratorExtensions.cs中实现。参考的官方dotnet/runtime库中System.Linq.Expressions/src/System/Linq/Expressions/Compiler/ILGen.cs
PS.appveyor编译不通过的问题在另外一个PR修复了。#256