-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support removing cache keys by pattern #401
Conversation
I don't have a good idea about Memcached as well. NotSupportedException is fine. |
Hi @catcherwong, did you have time to look into the PR? |
@xsoheilalizadeh In the last review, I pointed out some problems, you should fix them. 😄 |
test/EasyCaching.UnitTests/CachingTests/RedisCachingProviderTest.cs
Outdated
Show resolved
Hide resolved
Thanks @catcherwong, I addressed the requested changes. P.S: I am not sure which last review you mean because I didn't receive any reviews until 2 days ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For memcached would probably need to maintain a key of keys, aka allKeys. To make it consistent, you would need to move this pattern to the other Caches. Note, this does begin to lead into being able to support dependent Keys. |
Fixes #399
Only Memcached is not supported among the providers, if you have any ideas on how we can implement it I'd like to hear them.