Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dotnet v8 #495

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Upgrade to dotnet v8 #495

merged 3 commits into from
Jan 3, 2024

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Jan 2, 2024

  • .NET 6 Supports ends 12 Nov 2024, and both .NET 7 and 8 have been released.
  • Changing target framework of the examples only, the main library still target .NET Standard
  • .NET 8 is not available on Ubuntu 18.04, Ubuntu 18.04 already reached end of life (only paid Extended Security Maintenance is available), so it would make sense to just remove Ubuntu from AppVeyor

@kayoub5 kayoub5 requested review from chmorgan and PhyxionNL January 2, 2024 16:08
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbf3b58) 82.71% compared to head (c5bd3f0) 83.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   82.71%   83.13%   +0.42%     
==========================================
  Files          51       51              
  Lines        2823     2823              
  Branches      312      312              
==========================================
+ Hits         2335     2347      +12     
+ Misses        365      356       -9     
+ Partials      123      120       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PhyxionNL
PhyxionNL previously approved these changes Jan 3, 2024
@kayoub5 kayoub5 merged commit aeffcde into master Jan 3, 2024
10 checks passed
@kayoub5 kayoub5 deleted the chore/dotnet_v8 branch January 3, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants