Clean dotnet install logic #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kayoub5
commented
Jan 3, 2024
kayoub5
commented
- Semaphore CI no longer needed
- scripts are installing .NET 6, .NET 8 is pre-installed on most CI systems
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 81.12% 80.77% -0.36%
==========================================
Files 51 51
Lines 2824 2824
Branches 310 310
==========================================
- Hits 2291 2281 -10
- Misses 433 447 +14
+ Partials 100 96 -4 ☔ View full report in Codecov by Sentry. |
kayoub5
commented
Jan 5, 2024
# Conflicts: # .semaphore/semaphore.yml # scripts/install-dotnet.sh # scripts/install-windows.ps1
PhyxionNL
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.