Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): bump window's WindowsTargetPlatformMinVersion #2010

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

TatianaKapos
Copy link
Contributor

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

@TatianaKapos TatianaKapos requested a review from dcvz as a code owner May 9, 2023 17:41
@TatianaKapos TatianaKapos changed the title fix(windows): bump windows WindowsTargetPlatform fix(windows): bump window's WindowsTargetPlatformMinVersion May 22, 2023
Copy link
Collaborator

@bradfloodx bradfloodx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... David?

@TatianaKapos
Copy link
Contributor Author

@dcvz Would you mind looking at this PR when you have the chance? This will block RNW apps from using version .72

Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dcvz dcvz merged commit 32baacd into doublesymmetry:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants