Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): fix android example production build #2037

Merged

Conversation

puckey
Copy link
Collaborator

@puckey puckey commented Jun 20, 2023

Fixes the following error when building the example app for production:

> Task :app:compileReleaseJavaWithJavac FAILED
/Users/puckey/Downloads/react-native-track-player-main/example/android/app/src/main/java/com/example/MainApplication.java:63: error: cannot find symbol
        ReactNativeFlipper.initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
        ^
  symbol:   variable ReactNativeFlipper
  location: class MainApplication
1 error

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':app:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
java.lang.StackOverflowError (no error message)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 31s
76 actionable tasks: 76 executed
●  ./gradlew bundleRelease

BUILD SUCCESSFUL in 7s
84 actionable tasks: 10 executed, 74 up-to-date

@puckey puckey requested a review from dcvz as a code owner June 20, 2023 09:02
@puckey puckey enabled auto-merge (squash) June 20, 2023 09:02
@puckey
Copy link
Collaborator Author

puckey commented Jun 20, 2023

@jspizziri can you review?

@jspizziri jspizziri changed the title fix(android): example production build chore(example): fix android example production build Jun 20, 2023
@jspizziri
Copy link
Collaborator

@puckey lgtm,but could you update the commit message? I don't think we want this showing up as a big fix in the changelog since it only deals with the example and not the actual lib

@puckey puckey merged commit 09c570b into doublesymmetry:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants