fix(graphql,federation,#1051): check for undefined as well

doug-martin · Apr 12, 2021 · 46291c7 · 46291c7
1 parent 4343804
commit 46291c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/examples/federation/graphql-gateway/src/app.module.ts b/examples/federation/graphql-gateway/src/app.module.ts
@@ -13,6 +13,7 @@ import { GraphQLGatewayModule } from '@nestjs/graphql';
           { name: 'todo-items', url: 'http://localhost:3001/graphql' },
           { name: 'sub-tasks', url: 'http://localhost:3002/graphql' },
           { name: 'tags', url: 'http://localhost:3003/graphql' },
+          { name: 'user', url: 'http://localhost:3004/graphql' },
         ],
       },
     }),

diff --git a/packages/query-graphql/src/resolvers/relations/references-relation.resolver.ts b/packages/query-graphql/src/resolvers/relations/references-relation.resolver.ts
@@ -17,7 +17,10 @@ const pluckFields = <DTO, Relation>(dto: DTO, fieldMap: ReferencesKeys<DTO, Rela
 };
 
 const allFieldsAreNull = <Relation>(fields: Partial<Relation>): boolean => {
-  return Object.entries(fields).reduce<boolean>((previousNull, [, value]) => previousNull && value === null, true);
+  return Object.entries(fields).reduce<boolean>(
+    (previousNull, [, value]) => previousNull && (value === null || value === undefined),
+    true,
+  );
 };
 
 const ReferencesMixin = <DTO, Relation>(DTOClass: Class<DTO>, reference: ResolverRelationReference<DTO, Relation>) => <