Enhance calculation of average speed (with usage of new moving_duration) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation to base it on moving duration [fix dougfales#10]
…_duration enhancement
…file contains no time information (based on order) [fix dougfales#13]
doc75
force-pushed
the
dev_moving_duration
branch
from
82b1768 to
bc45253
Compare
| @@ -69,7 +75,10 @@ def append_point(pt) | |||
| @bounds.min_lon = pt.lon if pt.lon < @bounds.min_lon | |||
| @bounds.max_lat = pt.lat if pt.lat > @bounds.max_lat | |||
| @bounds.max_lon = pt.lon if pt.lon > @bounds.max_lon | |||
| @distance += haversine_distance(last_pt, pt) unless last_pt.nil? | |||
| unless last_pt.nil? | |||
There was a problem hiding this comment.
My preference is to invert this statement - if last_pt. unlesses are difficult to reason about.
There was a problem hiding this comment.
You are right, I also prefer the if notation. I just keep the original one.
PR update with if instead of unless.
|
One minor nit, but this looks good overall. |
|
If you could also bump version and publish it, that would be great (I did not change the version as I am not sure how you want to version it. |
|
OK, will do. |
andrewhao
added a commit
that referenced
this pull request
Aug 4, 2015
Enhance calculation of average speed (with usage of new moving_duration)
|
@doc75 Done, published |
|
@andrewhao It is working fine. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this PR:
Test added for all cases.