Remove pythagorean distance #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce_from; update tests.
…ing points at greater distances from each other.
|
Do you plan on merging this PR? |
|
Hi @moveson - thanks for your work! My apologies as I haven't had time to review this yet. I'll have a look now. |
|
LGTM - I'm going to merge, then bump to a new minor version for breaking API changes. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Segment#pythagorean_distance and TrackPoint#pythagorean_distance_from methods and one related test. It also adds two additional tests to the two remaining distance calculation methods (#haversine_distance_from and #law_of_cosines_distance_from) to ensure those methods work properly over distances spanning on the order of 100 km.
The PR also includes a bit of code formatting cleanup in the remaining distance methods (removing semicolons from line ends, making spacing consistent, and removing redundant return values).
This PR addresses Issue #27.