Add product to deal #322
Merged
Add product to deal #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tag to notifications
douglara
requested changes
May 15, 2024
douglara
requested changes
May 17, 2024
douglara
requested changes
May 20, 2024
Comment on lines
+138
to
+141
| def deal_products | ||
| @deal_products = @deal.deal_products | ||
| end | ||
|
|
There was a problem hiding this comment.
Aquele ponto da action ter dois comportamentos uma para o product e outra para o deal_product podemos ou colocar nesse controller do deal ou no controller deal_product
There was a problem hiding this comment.
Acho interessante deixar no deal msm, pq nesse caso ele vai exibir o deal_product somente na pagina do deal. Igual a logica dos events. As duas actions de listagem dos eventos, events_to_do e events_done, estão no deal, e n no controller events, pq a listagem desses eventos estão sendo renderizados na pagina do deal.
douglara
approved these changes
May 22, 2024
Comment on lines
179
to
182
| def product_params | ||
| params.require(:product).permit(:identifier, :amount_in_cents, :quantity_available, :description, :name, | ||
| attachments_attributes: %i[file _destroy id], custom_attributes: {}, additional_attributes: {}) | ||
| end |
There was a problem hiding this comment.
Dei um up aqui para evitar a duplicação
| end | ||
| context 'update product' do | ||
| it do | ||
| patch "/accounts/#{account.id}/deals/#{deal.id}/update_product?deal_product_id=#{deal_product.id}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.