Update the roster automatically when someone joins the user's current Seder #250

douglasnaphas · 2020-11-21T14:47:40Z

Use WebSockets.

douglasnaphas · 2020-11-21T14:51:02Z

Other uses of WebSockets can follow this, like pushing state changes to participants when the ringleader says everyone has joined.

douglasnaphas · 2020-11-29T14:03:00Z

Reference

nginx as a WebSocket reverse proxy, necessary for local development mimicking CloudFront.
https://blog.logrocket.com/websockets-tutorial-how-to-go-real-time-with-node-and-react-8e4693fbf843/
https://www.npmjs.com/package/websocket

douglasnaphas · 2021-08-25T05:03:48Z

TODO

Create a production build artifact for backend that excludes dev dependencies.
Does the connect handler have access to cookies? Yes. The default handler does not.
What happens to the response to the connect handler? Does the client get it? Could I put a pass a token from the connect handler?
~~Make a /ws-token endpoint. Authentication to the WebSocket API will require a token.~~ It uses the same cookie as the Rest API.
Share the cookie-checking code between the backend HTTP handler and the WebSocket connect handler. Lambda layers? Lambda@Edge or CloudFront functions? API Gateway custom authorizer? Can those be used with WebSockets? This will be complicated by the fact that the HTTP handler uses Express's cookie-parser. The cookie logic from the HTTP handler may need to be lifted out and rewritten.

gh-250 This rename has to happen because I'm about to have additional Lambda functions, specifically handlers for WebSocket events.

douglasnaphas · 2021-08-26T23:09:53Z

Prior to my creating a production build artifact, my backend Lambda code is 25 M zipped, 128 M unzipped.

Update: It's now 8.7 M zipped, 50 M unzipped.

gh-250 I want an asset bundle for my backend Lambda source that excludes dev dependencies, especially the tree rooted at jest, which brings in a lot of sizable deps.

gh-250 See the parent commit to this commit for motivation.

douglasnaphas · 2021-08-27T03:46:47Z

I think WebSocket Lambda code will just live in the backend/ directory side by side with the backend Lambda code.

douglasnaphas · 2021-08-27T04:46:46Z

Helpful code sample showing the types for Lambda's event and context, and the Lambda handler return type: https://levelup.gitconnected.com/how-to-use-typescript-for-aws-lambda-in-3-steps-1996243547eb.

gh-250 These are similar to the handlers and WebSocket API in room-app at https://github.com/dan-muller/room-app/blob/cf619d372222dcedaafd760fb28dbc97a9a0e488/packages/cdk/lib/room-app-stack.ts.

gh-250 I will probably not do this in prod. I want to verify that when cookies go in a wss request: 1. The cookie will arrive at the WS API and be logged. 2. The cookie will or will not (not sure which) be sent along with messages after the initial wss connection. 3. Cross-origin WSS requests work, while cross-origin REST requests do not.

gh-250 My last CloudFormation deployment failed with "Invalid request provided: AWS::CloudFront::OriginRequestPolicy" I think I'm supposed to use cookieBehavior to tell the distro what cookies to send, rather than including "Cookies" as a header to send.

douglasnaphas · 2021-08-27T22:47:20Z

With cookieBehavior: cloudfront.OriginRequestCookieBehavior.all(),, the connect handler receives the cookies, but the default handler does not.

douglasnaphas · 2021-08-27T22:51:33Z

When I did a cross-origin WSS request to wss://d2mrfshv1ypexe.cloudfront.net/ws/, it didn't include the cookies for d2mrfshv1ypexe.cloudfront.net. This makes sense given my cookies are all SameSite=strict.

gh-250 This should fail.

douglasnaphas · 2022-03-18T02:52:07Z

TODO

Make a WSAPI that I can manually connect to, and see the connection handler firing
Connection handler: Save the Connection ID within the Room Code partition. ~~Maybe even within the Room Code-Participant items.~~
Make it so that POSTing to the WS URL makes the POST contents show up in the roster.
Eliminate duplicates in the roster. No, check again should not cause the name to show up twice.
Are cookies sent with the disconnection request? Do I need to check them? Cookies are not received by the disconnect handler.
Don't send messages to disconnected clients. Have disconnect.js record a disconnect event in the room partition, and have handleJoin in stream.js consider disconnect events. I can add a test case for this.
Make a new user appearing in the seder in Dynamo POST to the WS URL.

douglasnaphas · 2022-03-18T02:58:40Z

Streaming from Dynamo to WS

douglasnaphas · 2022-03-18T23:26:30Z

Using promise() to send Dynamo requests

gh-250

gh-250 For some reason that is very hard to Google for, when I had {window.location.origin} in the JSX that I'm changing here, it put a comma before and after the string!

gh-250 The handlers need to authenticate the connection requests and associate Connection IDs to Room Codes.

gh-250

gh-250 I'm not finding the cookies

gh-250

gh-250 My query failed

gh-250 https://docs.aws.amazon.com/cdk/api/v2/docs/aws-apigatewayv2-alpha-readme.html#manage-connections-permission

gh-250 I'm not giving write access for now, because I want to avoid an infinite loop situation if I accidentally write to the db from the stream handler.

gh-250

gh-250 I can still see it there in the console, and my stream handler still fails with a message about the endpoint.

gh-250 Incredibly, a replace() function that works from the Node REPL won't trim wss:// from the start of my endpoint.

gh-250

gh-250 Considering listeners and edge cases, it's getting too confusing for a parent component (App) to pass a stateful WebSocket to pages.

gh-250

gh-250 The first participant (the leader) was getting displayed twice.

gh-250

gh-250 I don't know the room code when I get a disconnect event.

douglasnaphas added the websockets Uses WebSockets. label May 29, 2021

douglasnaphas added a commit that referenced this issue Aug 26, 2021

Rename fn to backendHandler

3e1debf

gh-250 This rename has to happen because I'm about to have additional Lambda functions, specifically handlers for WebSocket events.

douglasnaphas added a commit that referenced this issue Aug 27, 2021

Create a prod backend bundle, dev build

ab720ad

gh-250 I want an asset bundle for my backend Lambda source that excludes dev dependencies, especially the tree rooted at jest, which brings in a lot of sizable deps.

douglasnaphas added a commit that referenced this issue Aug 27, 2021

Build a devdeps-free artifact in prod

4b78cfa

gh-250 See the parent commit to this commit for motivation.

douglasnaphas added a commit that referenced this issue Mar 18, 2022

Test for WebSockets on the roster page

5a94759

gh-250 This should fail.

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Add a WebSockets API behind CloudFront

0ce5876

gh-250

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Grant the WS handlers RW access to the Table

f8ac33c

gh-250

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Use a variable URL on the Explain Page

c97f321

gh-250

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Fix relative import of schema

7f3d88f

gh-250

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Remove bizarre commas from variable in JSX

a3e1da1

gh-250 For some reason that is very hard to Google for, when I had {window.location.origin} in the JSX that I'm changing here, it put a comma before and after the string!

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Include cookies and query params in WS requests

01905c6

gh-250 The handlers need to authenticate the connection requests and associate Connection IDs to Room Codes.

douglasnaphas added a commit that referenced this issue Mar 19, 2022

Stream table changes to trigger.js

22ac283

gh-250

douglasnaphas added a commit that referenced this issue Mar 26, 2022

Handle multiple game cookies

a87f4d9

gh-250

douglasnaphas added a commit that referenced this issue Mar 26, 2022

Log the gameNameHash

995134f

gh-250 I'm not finding the cookies

douglasnaphas added a commit that referenced this issue Mar 26, 2022

Add a test for space after semicolon

d064300

gh-250

douglasnaphas added a commit that referenced this issue Mar 26, 2022

Handle space after semicolor in Cookie header

fdc4247

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Message the room about new participant joins

a094956

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Log the query error I'm currently getting

214b76c

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Identify happy path 1 case

2a41662

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Log the db query params as well, for debugging

c07966f

gh-250 My query failed

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Let the stream handler post to the WSAPI

f6564b8

gh-250 https://docs.aws.amazon.com/cdk/api/v2/docs/aws-apigatewayv2-alpha-readme.html#manage-connections-permission

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Let the stream handler query the DB

cad47a6

gh-250 I'm not giving write access for now, because I want to avoid an infinite loop situation if I accidentally write to the db from the stream handler.

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Format the WSAPI property for API call

4df7759

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Try harder to trim wss:// from the endpoint

feccbd7

gh-250 I can still see it there in the console, and my stream handler still fails with a message about the endpoint.

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Construct the WS API from its ID

6874640

gh-250 Incredibly, a replace() function that works from the Node REPL won't trim wss:// from the start of my endpoint.

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Remove unused testing-library imports

f278611

gh-250

douglasnaphas added a commit that referenced this issue Mar 27, 2022

Contain WS activity within one page at a time

b101246

gh-250 Considering listeners and edge cases, it's getting too confusing for a parent component (App) to pass a stateful WebSocket to pages.

douglasnaphas added a commit that referenced this issue Mar 28, 2022

Merge new participants into roster

c554963

gh-250

douglasnaphas added a commit that referenced this issue Mar 28, 2022

Wrap the newParticipant in an object

4a5238e

gh-250

douglasnaphas added a commit that referenced this issue Mar 28, 2022

Deserialize newParticipant on the front end

ee72295

gh-250

douglasnaphas added a commit that referenced this issue Mar 28, 2022

Don't display duplicate new participants

d439266

gh-250 The first participant (the leader) was getting displayed twice.

douglasnaphas added a commit that referenced this issue Mar 29, 2022

Sort participants case-insensitively in roster

6f2ecfa

gh-250

douglasnaphas added a commit that referenced this issue Mar 29, 2022

Format sortParticipants.js

78fca98

gh-250

douglasnaphas added a commit that referenced this issue Mar 29, 2022

Insert new participant in sorted order (front-end)

d3bcd1c

gh-250

douglasnaphas changed the title ~~Show a pop-up when someone joins the user's current Seder~~ Update the roster automatically when someone joins the user's current Seder Mar 30, 2022

douglasnaphas added a commit that referenced this issue Mar 31, 2022

Fix the name of the disconnect handler

089d737

gh-250

douglasnaphas mentioned this issue Apr 2, 2022

Show new participants as they join #407

Merged

douglasnaphas added a commit that referenced this issue Apr 8, 2022

Don't choke on disconnected clients

bae7716

gh-250

douglasnaphas added a commit that referenced this issue Apr 9, 2022

Partition disconnect Items by connection Id

62332b5

gh-250 I don't know the room code when I get a disconnect event.

douglasnaphas mentioned this issue Apr 9, 2022

Handle disconnects from roster #409

Merged

douglasnaphas closed this as completed in #409 Apr 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the roster automatically when someone joins the user's current Seder #250

Update the roster automatically when someone joins the user's current Seder #250

douglasnaphas commented Nov 21, 2020

douglasnaphas commented Nov 21, 2020

douglasnaphas commented Nov 29, 2020 •

edited

Loading

douglasnaphas commented Aug 25, 2021 •

edited

Loading

douglasnaphas commented Aug 26, 2021 •

edited

Loading

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021 •

edited

Loading

douglasnaphas commented Mar 18, 2022 •

edited

Loading

douglasnaphas commented Mar 18, 2022

douglasnaphas commented Mar 18, 2022

Update the roster automatically when someone joins the user's current Seder #250

Update the roster automatically when someone joins the user's current Seder #250

Comments

douglasnaphas commented Nov 21, 2020

douglasnaphas commented Nov 21, 2020

douglasnaphas commented Nov 29, 2020 • edited Loading

Reference

douglasnaphas commented Aug 25, 2021 • edited Loading

TODO

douglasnaphas commented Aug 26, 2021 • edited Loading

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021

douglasnaphas commented Aug 27, 2021 • edited Loading

douglasnaphas commented Mar 18, 2022 • edited Loading

TODO

douglasnaphas commented Mar 18, 2022

douglasnaphas commented Mar 18, 2022

douglasnaphas commented Nov 29, 2020 •

edited

Loading

douglasnaphas commented Aug 25, 2021 •

edited

Loading

douglasnaphas commented Aug 26, 2021 •

edited

Loading

douglasnaphas commented Aug 27, 2021 •

edited

Loading

douglasnaphas commented Mar 18, 2022 •

edited

Loading