Resolves the multiple emit from #280 (#286)

* Redid the integration tests using serverless-offline * Split offline and AWS editions of the integration tests * Run integration test in Github * Integration needs "npm run" * Re-enable node14.x tests * Demo the pino case doing double logging * Resolves the multiple emit from #280
dougmoscrop · Sep 21, 2023 · d2f123b · d2f123b
1 parent bbba01e
commit d2f123b
Show file tree

Hide file tree

Showing 11 changed files with 849 additions and 192 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,4 +15,5 @@ jobs:
       with:
         node-version: 18
     - run: npm ci
-    - run: npm test
+    - run: npm test
+    - run: npm run test:integration:offline
diff --git a/lib/response.js b/lib/response.js
@@ -127,10 +127,6 @@ module.exports = class ServerlessResponse extends http.ServerResponse {
         return true;
       },
     });
-
-    this.once('finish', () => {
-      this.emit('close')
-    });
   }
 
 };