Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to run Trim on Page Object Includes #392

Open
dougnoel opened this issue Jul 25, 2022 · 3 comments
Open

Need to run Trim on Page Object Includes #392

dougnoel opened this issue Jul 25, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dougnoel
Copy link
Owner

  1. Create a page object yaml file with two included files.
  2. Put a space after the comma before the second page object

RESULT: The second page object file cannot be found because there is a space before the name.
EXPECTED: The page object would be found because the name is trimmed before the search happens.

This should probably be fixed in the FileManager

@dougnoel dougnoel added bug Something isn't working good first issue Good for newcomers labels Jul 25, 2022
@amehta-scottlogic
Copy link

Hi, could I take a look at this issue?

@amehta-scottlogic
Copy link

Hi, I created a PR for this issue here: #405

I think this addresses the issue, but not sure if there needs to be a better suited integration test? I couldn't figure out the right way to create a page object and have the included pages also be loaded

@dougnoel
Copy link
Owner Author

dougnoel commented Aug 1, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants