Skip to content

Commit

Permalink
fix GCP cloud storage client bug, cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
douwevandermeij committed Aug 3, 2022
1 parent 19404a7 commit 42d1f2e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion fractal/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Fractal is a scaffolding toolkit for building SOLID logic for your Python applications."""

__version__ = "0.4.12"
__version__ = "0.4.13"

from abc import ABC

Expand Down
10 changes: 1 addition & 9 deletions fractal/contrib/fastapi/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

try:
import sentry_sdk
from sentry_sdk.integrations.fastapi import FastApiIntegration
from sentry_sdk.integrations.starlette import StarletteIntegration
except ImportError:
sentry = False
else:
Expand Down Expand Up @@ -40,13 +38,7 @@ def install_fastapi(settings: Settings):

if sentry:
if sentry_dsn := getattr(settings, "SENTRY_DSN", ""):
sentry_sdk.init(
dsn=sentry_dsn,
integrations=[
# StarletteIntegration(),
# FastApiIntegration(),
],
)
sentry_sdk.init(dsn=sentry_dsn)

@app.exception_handler(DomainException)
def unicorn_domain_exception_handler(request: Request, exc: DomainException):
Expand Down
2 changes: 1 addition & 1 deletion fractal/contrib/gcp/cloudstorage/repositories.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

def get_cloudstorage_client(settings: Settings):
if not hasattr(settings, "cloudstorage_client"):
settings.cloudstorage_client = storage.client()
settings.cloudstorage_client = storage.Client()
return settings.cloudstorage_client


Expand Down

0 comments on commit 42d1f2e

Please sign in to comment.