Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: improve xlog with less and robust api #321

Merged
merged 10 commits into from
Jul 11, 2022
Merged

refactor!: improve xlog with less and robust api #321

merged 10 commits into from
Jul 11, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented May 10, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq requested a review from hjxp May 10, 2022 08:45
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #321 (4504d44) into master (f38db3d) will decrease coverage by 0.48%.
The diff coverage is 40.27%.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   34.10%   33.61%   -0.49%     
==========================================
  Files          88       89       +1     
  Lines        6445     6268     -177     
==========================================
- Hits         2198     2107      -91     
+ Misses       4114     4034      -80     
+ Partials      133      127       -6     
Impacted Files Coverage Δ
pkg/client/rocketmq/init.go 1.78% <0.00%> (ø)
pkg/client/rocketmq/option.go 71.08% <0.00%> (ø)
pkg/client/rocketmq/producer.go 44.71% <0.00%> (ø)
pkg/conf/datasource/apollo/register.go 3.33% <0.00%> (ø)
pkg/executor/xxl/options.go 93.24% <0.00%> (ø)
pkg/store/gorm/config.go 0.00% <0.00%> (ø)
pkg/store/gorm/init.go 30.76% <ø> (-11.54%) ⬇️
pkg/util/xgo/init.go 10.00% <ø> (ø)
pkg/xlog/context.go 56.52% <0.00%> (ø)
pkg/xlog/field.go 0.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38db3d...4504d44. Read the comment docs.

@sysulq sysulq force-pushed the feat/logv2 branch 3 times, most recently from fd01b62 to 2d97e48 Compare June 8, 2022 06:21
@sysulq sysulq changed the title feat: add log v2 package feat!: add log v2 package Jun 9, 2022
@sysulq sysulq changed the title feat!: add log v2 package refactor!: improve xlog package Jun 9, 2022
@sysulq sysulq changed the title refactor!: improve xlog package refactor!: improve xlog with less and robust api Jun 9, 2022
@sysulq sysulq changed the title refactor!: improve xlog with less and robust api refactor: improve xlog with less and robust api Jun 16, 2022
@sysulq sysulq changed the title refactor: improve xlog with less and robust api refactor!: improve xlog with less and robust api Jun 16, 2022
@sysulq sysulq merged commit 23ea45d into master Jul 11, 2022
@sysulq sysulq deleted the feat/logv2 branch August 24, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants