Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the var of span occurrence Unexpected.#571 #572

Merged
merged 1 commit into from
Nov 21, 2022
Merged

fix: the var of span occurrence Unexpected.#571 #572

merged 1 commit into from
Nov 21, 2022

Conversation

DenisYin66
Copy link
Contributor

Describe what this PR does / why we need it

Does this pull request fix one is

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #572 (3ffaff3) into master (7f255f8) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   50.81%   50.96%   +0.15%     
==========================================
  Files         105      105              
  Lines        6963     6964       +1     
==========================================
+ Hits         3538     3549      +11     
+ Misses       3167     3159       -8     
+ Partials      258      256       -2     
Impacted Files Coverage Δ
pkg/client/rocketmq/consumer.go 38.46% <0.00%> (-0.18%) ⬇️
pkg/registry/etcdv3/registry.go 74.22% <0.00%> (+3.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sysulq sysulq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants