feat: add redis cluster #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #938 +/- ##
===========================================
- Coverage 53.16% 33.01% -20.15%
===========================================
Files 202 162 -40
Lines 11335 8538 -2797
===========================================
- Hits 6026 2819 -3207
- Misses 4857 5486 +629
+ Partials 452 233 -219
|
|
建议新增一种cluster类型，和stub类型同级 |
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
|
@city55238 我理解的，是不是把cluster和stub client完全独立会更好呢？ |
|
redis stub模式也是在第二层的，我理解cluster也应该是在这个位置 |
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
|
@city55238 可以参考现有的redis单测，加下cluster的测试用例 |
|
已经补充过了，但是nomal start的样例需要你那边有一个集群模式的redis，不然单测跑不过 |
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
requested changes
Aug 9, 2023
| "github.com/samber/lo" | ||
| "go.uber.org/zap" | ||
| ) | ||
|
|
There was a problem hiding this comment.
这里如果用组合会不会更简单些
type ClusterClient struct {
*redis.ClusterClient
config *Config
}
pkg/client/redis/cluster.go
Outdated
| config *Config | ||
| } | ||
|
|
||
| func (ins *ClusterClient) CmdOnCluster() *redis.ClusterClient { |
pkg/client/redis/cluster.go
Outdated
| ) | ||
|
|
||
| type ClusterClient struct { | ||
| cluster *redis.ClusterClient |
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
requested changes
Aug 10, 2023
city55238
temporarily deployed
to
tablestore-live
GitHub Actions
Inactive
sysulq
approved these changes
Aug 11, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
redis支持集群模式
Does this pull request fix one issue?
feat
Describe how you did it
在原生redis-go sdk的基础上接入cluster,修改cluster redis配置的加载方式
cluster配置支持云厂商连接："r-bp1zxszhcgatnx****.redis.rds.aliyuncs.com:6379"
也支持自定义node集群连接： ["127.0.0.1:6379","127.0.0.1:6370","127.0.0.1:6371"]
配置示例：
[jupiter.redis.exampleserver]
[jupiter.redis.exampleserver.cluster]
debug = false
maxIdle = 10
maxActive = 50
dialTimeout = "2s"
readTimeout = "2s"
idleTimeout = "60s"
enableAccessLog = false
addr = ["r-bp1zxszhcgatnx****.redis.rds.aliyuncs.com:6379"] # ["127.0.0.1:6379","127.0.0.1:6370","127.0.0.1:6371"]
username = "root"
password = "xxxxxx"
Describe how to verify it
Special notes for reviews