Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong exit code when error thrown during custom transform #43

Closed
chmontgomery opened this issue Feb 4, 2015 · 0 comments
Closed

Wrong exit code when error thrown during custom transform #43

chmontgomery opened this issue Feb 4, 2015 · 0 comments
Labels
Milestone

Comments

@chmontgomery
Copy link
Contributor

When there is an error during a custom transform, the stream stops and prints an error properly but the exit code is wrong. The exit code is 0 but I expect it to be 1.

For example, if using require('gulp-bundle-assets').transformHelper.less() and there is a compile error inside a .less file, the stream will stop and print the error, but the node process will simply exit with the wrong code.

One possible solution is to simply process.exit(1) inside the stream-files.handleTransformError, however the ideal solution is to bubble up the error to gulp that the stream failed.

@chmontgomery chmontgomery added this to the Ice Box milestone Feb 4, 2015
chmontgomery added a commit that referenced this issue Mar 1, 2015
fix stream error handling for bundling and watching. Fixes #43 and #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant