-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hooks): check state chage via deep compare #1558
Conversation
@silviuaavram Can you please update to pass checks and merge it ? |
@danichim this fix is not enough unfortunately, I tried publishing an alpha 8.2.4-alpha.3 with the fix and checked a repro sandbox, still broken ... I am currently still looking into it |
Got it. It's formik, they had to fix something in 2.4.2 as part of React 18. Will update this PR to get a green build, and will update accordingly all our issues. Thanks! |
🎉 This PR is included in version 8.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@danichim this ticket has been fixed, tested and closed. If you still have any other issue please create a new ticket with a repro guide and a codesandbox to repro the issue. thanks! |
Thanks @silviuaavram for your time, #1564 is my issue. Have a nice day ! |
What:
Deep compare the previous state with the next state.
Why:
Avoid unnecessary calls of onChange props.
Fixes #1534.
Fixes #1540.
Fixes #1511.
Fixes #1447.
How:
Check each property from state instead of using referential comparison of the whole state object.
Checklist: