Skip to content
This repository has been archived by the owner on Sep 17, 2020. It is now read-only.

Plugin cannot find config.xml when it is located in www folder #33

Closed
henkkelder opened this issue Nov 9, 2018 · 3 comments
Closed
Labels

Comments

@henkkelder
Copy link

As the tittle says.
Since I also use phonegap build my config.xml must be located in the www folder.

@dpa99c
Copy link
Owner

dpa99c commented Nov 9, 2018

This plugin relies on hook scripts which are not supported by Phonegap Build so it will not work.

@dpa99c dpa99c closed this as completed Nov 9, 2018
@henkkelder
Copy link
Author

Thats not my point. Its just the location of config.xml where the plugin fails when using with the CLI.

Officially Cordova supports to have the config.sys in the project folder or in de www folder. Your plugin lacks support for the latter.

I build android locally on my own pc, but IOS using PGB.
Since PGB wants the plugin in the www folder I must have it there.
But then my local builds give errors when I include your plugin.

@dpa99c
Copy link
Owner

dpa99c commented Nov 9, 2018

OK, I misunderstood.
It should be possible to detect the location of config.xml in the hook scripts.

@dpa99c dpa99c reopened this Nov 9, 2018
@dpa99c dpa99c added the TODO label Nov 9, 2018
dpa99c added a commit that referenced this issue Nov 12, 2018
- Rework plugin to use a single Gradle file to make it work with all versions of cordova-android@6 and cordova-android@7. Resolves dpa99c/cordova-android-play-services-gradle-release#17.
- Support for www/config.xml. Resolves #33.
dpa99c added a commit to dpa99c/cordova-android-firebase-gradle-release that referenced this issue Nov 12, 2018
- Rework plugin to use a single Gradle file to make it work with all versions of cordova-android@6 and cordova-android@7. Resolves dpa99c/cordova-android-play-services-gradle-release#17.
- Support for www/config.xml. Resolves dpa99c/cordova-android-support-gradle-release#33.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants