Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Icon in foreground data message #343

Closed
maksymov opened this issue Mar 16, 2020 · 0 comments
Closed

Large Icon in foreground data message #343

maksymov opened this issue Mar 16, 2020 · 0 comments
Labels
android Relates to Android platform bug Something isn't working properly runtime issue An issue related to app runtime

Comments

@maksymov
Copy link

Describe the bug
When I send a data-message in foreground, I see a large icon with my app icon. But google recommendation about this icon:

Large icon set using the setLargeIcon () element (optional). It is usually used for contact photos. Don't place the app icon here.

To Reproduce
Steps to reproduce the behavior:

data_message = {
        "notification_foreground": "true",
        "notification_title": subject,
        "notification_body" : message[:100],
        'notification_android_icon': 'ic_stat_avex_logo',
        'notification_android_color': '#FF336699',
        "datetime" : "date and time",
        "author" : "Author of comment",
        "rep_id" : "Report_id"
    }
push_service.notify_single_device(
        registration_id=feedback_token,
        data_message=data_message,
        message_title=subject,
        message_body=message[:100] )

Expected behavior
LargeIcon should be empty, like when background message.

Screenshots
screenshot

Console Logs
No error logs

Plugin Version

cordova-plugin-androidx 1.0.2 "cordova-plugin-androidx"
cordova-plugin-androidx-adapter 1.1.0 "cordova-plugin-androidx-adapter"
cordova-plugin-device 2.0.3 "Device"
cordova-plugin-file 6.0.2 "File"
cordova-plugin-firebasex 8.1.1 "Google Firebase Plugin"
cordova-plugin-vibration 2.1.6 "Vibration"
cordova-plugin-whitelist 1.3.4 "Whitelist"

Smartphone (please complete the following information):

  • Device: Sony Xperia XZ1 Compact
  • OS: Android 9
  • Browser WebView (80.0.3987.132)
@dpa99c dpa99c added android Relates to Android platform bug Something isn't working properly runtime issue An issue related to app runtime labels Mar 16, 2020
@dpa99c dpa99c closed this as completed in 5d497b3 Mar 16, 2020
@dpa99c dpa99c added the ready for release Something has been implemented and is awaiting release to npm label Mar 16, 2020
@dpa99c dpa99c removed the ready for release Something has been implemented and is awaiting release to npm label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Relates to Android platform bug Something isn't working properly runtime issue An issue related to app runtime
Projects
None yet
Development

No branches or pull requests

2 participants