Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed retrieving Xcode project path #234

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Fixed retrieving Xcode project path #234

merged 1 commit into from
Nov 23, 2019

Conversation

pjorquera
Copy link

@pjorquera pjorquera commented Nov 22, 2019

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

When installing plugin for iOS, the plugin doesn't add custom run script required for Crashlytics in Xcode generated project. This PR fixes that retrieving correctly the Xcode project path.

Does this PR introduce a breaking change?

  • Yes
  • No

@ghost
Copy link

ghost commented Nov 22, 2019

DeepCode Report (#ca39d1)

DeepCode analyzed this pull request.
There are no new issues.

@dpa99c dpa99c merged commit 5c977a3 into dpa99c:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants