Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InAppMessaging for iOS and Android #312

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Added InAppMessaging for iOS and Android #312

merged 4 commits into from
Feb 28, 2020

Conversation

ianitsky
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Add firebase InAppMessaging as described in he link:
https://firebase.google.com/docs/in-app-messaging/get-started?platform=android

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Functional testing, using emulators and real devices

What testing has been done on existing functionality?

Using emulators and real devices

Other information

@ghost
Copy link

ghost commented Feb 24, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.106 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@dpa99c
Copy link
Owner

dpa99c commented Feb 28, 2020

Thanks for this. I will probably merge this into the dev branch in which I'm currently implementing the Firestore API and it can go out in the same release.

@dpa99c dpa99c changed the base branch from master to dev February 28, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants