Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get info fori os #363

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Get info fori os #363

merged 3 commits into from
Apr 10, 2020

Conversation

Edmu
Copy link

@Edmu Edmu commented Apr 8, 2020

getInfo on iOS should return similar (to android) info object on success callback.

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

getInfo implementation for iOS

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Ran on device to verify the implementation return desired result w/o crashes.

What testing has been done on existing functionality?

should not impact existing functionality

@ghost
Copy link

ghost commented Apr 8, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.11 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@dpa99c dpa99c merged commit 7118d8c into dpa99c:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants