Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom locations for platform config files using plugin variables #465

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

zdm
Copy link

@zdm zdm commented Jul 17, 2020

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [ x] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

This PR adds possibility to set custom location for google-services.json and GoogleService-Info.plist using ANDROID_KEY and IOS_KEY variables.

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

@zdm
Copy link
Author

zdm commented Jul 17, 2020

Now users can define custom locations in config.xml, or package.json:

<plugin name="cordova-plugin-firebasex">
        <variable name="ANDROID_KEY" value="resources/android/google-services.json" />
        <variable name="IOS_KEY" value="resources/ios/GoogleService-Info.plist" />
    </plugin>

If custom settings are present - they will override default hardcoded paths.

@dpa99c
Copy link
Owner

dpa99c commented Jul 23, 2020

Thanks, for this - I'll merge this now but I'll rename *_KEY to *_FIREBASE_CONFIG_FILEPATH so it's clearer what the variable does from its name.

@dpa99c dpa99c merged commit 1d99493 into dpa99c:master Jul 23, 2020
@zdm
Copy link
Author

zdm commented Jul 23, 2020

ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants