Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Actionable notifications: foreground, background, destructive #487

Closed
wants to merge 4 commits into from

Conversation

roman-rr
Copy link

PR Type

Added options for selectable items: foreground will allow to open application after select option. destructive make button in red color;

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

pn-actions.json example

{
  "PushNotificationActions": [
    {
      "category": "news",
      "actions": [
        {
          "id": "read", "title": "Read", "foreground": "true"
        },
        {
          "id": "skip", "title": "Skip", "destructive": "true"
        },
        {
          "id": "add", "title": "Add to list"
        }
      ]
    }
  ] 
}

@ghost
Copy link

ghost commented Aug 19, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.551 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@roman-rr
Copy link
Author

Last 3 commits a custom solution for one app and here suddenly pushed. But foreground and destructive mode still can be good cherrypicked

dpa99c pushed a commit that referenced this pull request Sep 15, 2020
@dpa99c
Copy link
Owner

dpa99c commented Sep 15, 2020

Thanks I have cherrypicked the relevant commit and pushed out in the 11.0.0 release

@dpa99c dpa99c closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants