Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPTA-106] Fix actions warnings #48

Merged
merged 6 commits into from
Jun 6, 2024
Merged

[SDPTA-106] Fix actions warnings #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1061568
[SDPTA-106] Fix actions warnings
tim-yao Jun 6, 2024
b1d16a5
Change version for test
tim-yao Jun 6, 2024
f4ea68e
use main for work conclusion
tim-yao Jun 6, 2024
0d2afb9
fix-artifacts
tim-yao Jun 6, 2024
fe9325e
Remove redundant steps
tim-yao Jun 6, 2024
cdf0cbd
revert the test changes
tim-yao Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/test-report/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ runs:
using: 'composite'
steps:
- name: Archive artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: ${{ inputs.report_name }}
path: reports
path: /app/reports/
- name: Publish Test Report
uses: mikepenz/action-junit-report@v3
uses: mikepenz/action-junit-report@v4
if: always()
with:
report_paths: '/app/reports/report.xml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ jobs:
echo "==> No Postman API test collection is found. Skip the test."
fi
- name: Upload core API test report
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: core-test-report
path: /app/report/tide.collection.report.html
- name: Upload custom API test report
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: custom-test-report
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build_unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
run: tar -czf build-artifacts.tar.gz .nuxt

- name: Archive build artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-artifacts
path: build-artifacts.tar.gz
Expand All @@ -71,7 +71,7 @@ jobs:
uses: actions/checkout@v2

- name: Download build artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build-artifacts

Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
JEST_JUNIT_OUTPUT_DIR: test-results/unit/

- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results
path: test-results
6 changes: 3 additions & 3 deletions .github/workflows/notify_slack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
JOB_ID: ${{ inputs.workflow_id }}
REUSABLE_WORKFLOW_NAME: ${{ inputs.workflow_reusable_name }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact_name }}
- name: prepare-report
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
echo "REPORT_TEXT=:crying_cat_face: No report found. Testing may have been skipped." >> $GITHUB_ENV
fi
- name: sdp-test-report-success
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
if: env.WORKFLOW_CONCLUSION == 'success'
env:
REPO_NAME: ${{ github.repository }}
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
]
}
- name: sdp-test-report-fail
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
if: env.WORKFLOW_CONCLUSION != 'success'
with:
channel-id: ${{ inputs.slack_channel }}
Expand Down
19 changes: 1 addition & 18 deletions .github/workflows/run_e2e_be.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get repo name
id: repo_name
run: echo "::set-output name=REPO_NAME::$(echo ${GITHUB_REPOSITORY#*/})"
Comment on lines -115 to -117
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant, not used at all. There is a warning for using set-output, so I decide to remove it.

-
name: Check browsers
run: |
Expand Down Expand Up @@ -151,13 +148,6 @@ jobs:
uses: dpc-sdp/github-actions/.github/actions/test-report@main
with:
report_name: 'test-reports-${{ inputs.name }}'
-
name: Upload test results
uses: actions/upload-artifact@v3
if: always()
with:
name: test-results
path: /app/reports/
Comment on lines -154 to -160
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated test report uploading, removed.

-
name: 'Add failed test result status to CMS'
if: inputs.test_status && failure()
Expand All @@ -170,13 +160,6 @@ jobs:
run: |
cd /app
TEST_STATUS=pass node -r ts-node/register -r tsconfig-paths/register scripts/addTestResult.ts
-
name: Store Cucumber Cloud test report URL
uses: actions/upload-artifact@v3
if: always()
with:
name: ${{ inputs.name }}-report-url
path: /app/reports/report-url.txt
Comment on lines -173 to -179
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication, removed.

notify_slack:
uses: ./.github/workflows/notify_slack.yml
if: |
Expand All @@ -196,7 +179,7 @@ jobs:
workflow_reusable_name: "run_e2e_be"
test_type: ${{ inputs.test_type }}
test_subtype: ${{ inputs.test_subtype }}
artifact_name: "${{ inputs.name }}-report-url"
artifact_name: "test-reports-${{ inputs.name }}"
be_url: ${{ inputs.be_url }}
project: ${{ inputs.project }}
slack_channel: ${{ inputs.slack_channel }}
12 changes: 1 addition & 11 deletions .github/workflows/run_e2e_fe.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get repo name
id: repo_name
run: echo "::set-output name=REPO_NAME::$(echo ${GITHUB_REPOSITORY#*/})"
-
name: Check browsers
run: |
Expand Down Expand Up @@ -162,13 +159,6 @@ jobs:
uses: dpc-sdp/github-actions/.github/actions/test-report@main
with:
report_name: 'test-reports-${{ inputs.name }}'
-
name: Store Cucumber Cloud test report URL
uses: actions/upload-artifact@v3
if: always()
with:
name: ${{ inputs.name }}-report-url
path: /app/reports/report-url.txt
notify_slack:
uses: ./.github/workflows/notify_slack.yml
if: |
Expand All @@ -188,7 +178,7 @@ jobs:
workflow_reusable_name: "run_e2e_fe"
test_type: ${{ inputs.test_type }}
test_subtype: ${{ inputs.test_subtype }}
artifact_name: "${{ inputs.name }}-report-url"
artifact_name: "test-reports-${{ inputs.name }}"
fe_url: ${{ inputs.fe_url }}
be_url: ${{ inputs.be_url }}
project: ${{ inputs.project }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tf_diffscheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:

- name: Send Slack notification
id: notify_slack
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
if: steps.plan.outputs.exitcode == 2
env:
REPO_NAME: ${{ github.repository }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tide_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
run: |
/app/.circleci/test-artifacts.sh
- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: behat-results
Expand Down