Added custom icon support for adding new and overriding existing icons. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-yao
reviewed
May 16, 2019
| // Add default icons on first call. | ||
| // For correct overrides; this must run after custom icons have been added. | ||
| if (!hasRunOnce) { | ||
| hasRunOnce = true |
There was a problem hiding this comment.
This will make dev mode hot reload not working properly.
There was a problem hiding this comment.
Added ability to invoke a reset to these properties and added it before the first custom library is called. This allows require.context() calls be reset in dev hot reloading.
packages/Atoms/Icon/icon-library.js
Outdated
| @@ -0,0 +1,44 @@ | |||
| const iconProps = {} | |||
There was a problem hiding this comment.
In dev mode, hot reload will run code multiple times if you edited the config file, so this global var value may will be kept instead of reset to {}.
There was a problem hiding this comment.
Added ability to invoke a reset to these properties and added it before the first custom library is called. This allows require.context() calls be reset in dev hot reloading.
tim-yao
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tim-yao - This is my take on a custom icon solution. I'll try implement on nuxt and see if I can update the other branch.