Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for svgloader adding duplicate config #435

Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix for svgloader adding duplicate config #435

merged 2 commits into from
Jul 16, 2019

Conversation

dylankelly
Copy link
Contributor

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-

Changed

  1. Fix svgLoader being added twice
  2. Resolve project root with app-root-path package - https://www.npmjs.com/package/app-root-path - Handles cross platform path resolution

Screenshots

@dylankelly dylankelly requested a review from tim-yao July 16, 2019 01:57
@dylankelly dylankelly self-assigned this Jul 16, 2019
@dylankelly dylankelly merged commit c7a3e2a into develop Jul 16, 2019
@dylankelly dylankelly deleted the fix/svgloader-issue branch July 16, 2019 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-yao tim-yao tim-yao approved these changes

Assignees

@dylankelly dylankelly

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylankelly @tim-yao