[SDPA-3192] Added Wordwrap mixin and used in rpl_banner_title. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-yao
reviewed
Sep 30, 2019
| @@ -0,0 +1,3 @@ | |||
| @mixin rpl_word_wrap($rpl-word-wrap) { | |||
| word-wrap: $rpl-word-wrap; | |||
| } | |||
There was a problem hiding this comment.
Please remember to add an empty line in the end of file.
| @@ -276,6 +277,7 @@ export default { | |||
| &__title { | |||
| @include rpl_typography_ruleset($rpl-hero-banner-title-typography-ruleset); | |||
| @include rpl_text_color($rpl-hero-banner-title-color); | |||
| @include rpl_word_wrap($rpl-hero-banner-title-word-wrap); | |||
There was a problem hiding this comment.
It just one line of simple css word-wrap: break-word, may not need to be a mixin. Any good reason for it?
| @@ -180,6 +180,7 @@ export default { | |||
| 'xxxl': ('pos': 'right', 'v-offset': $rpl-hero-banner-background-graphic-v-offset-xxl), | |||
| '2660px': ('pos': 'right') | |||
| ) !default; | |||
| $rpl-hero-banner-title-word-wrap: break-word !default; | |||
There was a problem hiding this comment.
I also not thinking of a setting for this, any reason need this to be configurable?
tim-yao
approved these changes
Sep 30, 2019
MdNadimHossain
deleted the
feature/SDPA-3192-News-title-fix-for-long-words
branch
tim-yao
added a commit
that referenced
this pull request
Oct 21, 2019
* develop: (63 commits) SDPA-3169 adds new branding (#567) v1.3.1 Update create ripple app (#570) [SDPL-96] Split fieldRplSelect into its own component (#566) Fixed markup encode issue (#572) [SDPA-3207] Added style change for CallToAction to xs screen design. (#557) Updated the domain for the MyVIC endpoints in the MyVIC Maps. (#573) v1.3.0 [SDPA-3270] Upgraded Nuxt to v2.9.2 (#561) [SDPA-3306] add mapping example (#555) [SDPA-3338] Fixed markup decode issue (#562) [SDPA-2949] Fix: Search results query to support filter object. (#528) [SDPA-3203] Added pagination correct number highlighting fix. (#559) [SDPA-3125] Added Flex for the small screen to make it two columns. (#552) [SDPA-3174] Added hero banner title size for smal & large screen. (#553) [SDPA-3192] Added Wordwrap mixin and used in rpl_banner_title. (#551) [SDPA-1967] Updated Honour role apply button text to match the design. (#550) [SDPA-2470] Added bottom padding for cta component in xs screen. (#549) Fix issues with e2e-vic-gov-au tests (#556) v1.3.0-alpha.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-3192
Changed
Screenshots
Following screenshots are from mobile, Ipad and Ipad pro screen sizes -
