refactor: interface query on m-m joins and select specific columns #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor/interface-query
…efactor/interface-query
…efactor/interface-query
This was referenced Jul 3, 2020
Merged
ashb
added a commit
to ashb/Flask-AppBuilder
that referenced
this pull request
Oct 22, 2020
The refactor in dpgaspar#1398 changes the `get()` function, and mistakenly always applied the PK filter, even in the case of composite keys. (The else block of `if self.is_pk_composite` applied it again, so it was actually applying the same filter twice, which didn't break anything, but was not needed)
6 tasks
ashb
added a commit
to ashb/Flask-AppBuilder
that referenced
this pull request
Oct 22, 2020
The refactor in dpgaspar#1398 changes the `get()` function, and mistakenly always applied the PK filter, even in the case of composite keys. (The else block of `if self.is_pk_composite` applied it again, so it was actually applying the same filter twice, which didn't break anything, but was not needed)
dpgaspar
pushed a commit
that referenced
this pull request
Oct 25, 2020
The refactor in #1398 changes the `get()` function, and mistakenly always applied the PK filter, even in the case of composite keys. (The else block of `if self.is_pk_composite` applied it again, so it was actually applying the same filter twice, which didn't break anything, but was not needed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Flask-AppBuilder SQLAlchemy Interface query