Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable rate limit by default #1999

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix: disable rate limit by default #1999

merged 3 commits into from
Feb 23, 2023

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Feb 23, 2023

Description

Disable auth rate limiting by default, will break dependencies unit tests and integration tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar merged commit 23dff84 into master Feb 23, 2023
@dpgaspar dpgaspar deleted the fix/off-rate-limit branch February 23, 2023 15:19
potiuk added a commit to potiuk/airflow that referenced this pull request Mar 4, 2023
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.
potiuk added a commit to apache/airflow that referenced this pull request Mar 4, 2023
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 12, 2023
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.

GitOrigin-RevId: b7f05008ae45fc208456f7f64c19d08ad1cf7313
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2023
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.

GitOrigin-RevId: b7f05008ae45fc208456f7f64c19d08ad1cf7313
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 19, 2024
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.

GitOrigin-RevId: b7f05008ae45fc208456f7f64c19d08ad1cf7313
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 8, 2024
FAB 4.3.0 added rate limiting and we would like to upgrade to this
version.

This requires to bring some of the changes from the PRs merged in
Flask App Builder:

* dpgaspar/Flask-AppBuilder#1976
* dpgaspar/Flask-AppBuilder#1997
* dpgaspar/Flask-AppBuilder#1999

While Flask App Builder disabled rate limitig by default, Airlfow
is "end product" using it and we decided to enable it.

GitOrigin-RevId: b7f05008ae45fc208456f7f64c19d08ad1cf7313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant